Add SSH key for all relevant workflows #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark Results
| Benchmark suite | Current: 6ddc37f | Previous: 95a8b55 | Ratio |
|---|---|---|---|
normal + bijector/meanfield/ForwardDiff |
488783352 ns |
||
normal + bijector/meanfield/ReverseDiff |
193833703 ns |
This comment was automatically generated by workflow using github-action-benchmark.
|
Hi @penelopeysm , the buildkite integration was failing because it is currently not configured. I just added an empty pipeline in #98 so that should fix that problem. |
|
Is this ready to merge? |
|
Sorry I forgot about this! Yes, it should be, at long as you are happy. I'll fix merge conflicts. |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SSH keys for CompatHelper, Documenter, and TagBot workflows, so that they actually work properly.
(Context: TuringLang/Turing.jl#2347 requires docs for AdvancedVI 0.2, and the lack of a SSH key here means that Documenter currently only generates 'dev' docs i.e. current master branch. ... Although I notice that AdvancedVI 0.2 has no docs, so this PR alone doesn't fully solve the problem. Once this is merged I'll follow up with a PR to the v0.2-backport branch.)
By the way, the buildkite integration hasn't ever passed on the master branch. I propose to also remove it.